FIX: Discobot exception when site_contact_username is promoted #11666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviltrout
approved these changes
Jan 8, 2021
ZogStriP
reviewed
Jan 8, 2021
Because the site admin is sending a message to themselves, there is only one user in the topic_allowed_users, and `.last` returns nil. Attempt to recognize this situation and continue, or bail without doing anything if this somehow happens another way.
riking
force-pushed
the
site-contact-promotion
branch
from
bec3ebf
to
127f83f
Compare
ZogStriP
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the site admin is sending a message to themselves, there is only one user in the topic_allowed_users, and
.lastreturns nil.Attempt to recognize this situation and continue, or bail without doing anything if this somehow happens another way.