New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce complexity of TopicView #1185

Merged
merged 1 commit into from Jul 15, 2013

Conversation

4 participants
@novemberkilo
Contributor

novemberkilo commented Jul 12, 2013

The results of a personally therapeutic refactoring session (thanks @kytrinyx!)

Still much to do but this will reduce the complexity scores for TopicView

Along with minor extractions/cleanup, the main thing this PR contains is the introduction of a new class FilterBestPosts along with supporting specs

Navin
Refactor TopicView - extract filter method to FilterBestPosts
Still much to do but this should reduce the complexity scores
for TopicView
@discoursebot

This comment has been minimized.

Show comment
Hide comment
@discoursebot

discoursebot Jul 12, 2013

You've signed the CLA, novemberkilo. Thank you! This pull request is ready for review.

discoursebot commented Jul 12, 2013

You've signed the CLA, novemberkilo. Thank you! This pull request is ready for review.

@SamSaffron

This comment has been minimized.

Show comment
Hide comment
@SamSaffron

SamSaffron Jul 15, 2013

Member

very happy with this, will let @eviltrout yank it in, thanks heaps

Member

SamSaffron commented Jul 15, 2013

very happy with this, will let @eviltrout yank it in, thanks heaps

eviltrout added a commit that referenced this pull request Jul 15, 2013

Merge pull request #1185 from novemberkilo/master
Reduce complexity of TopicView

@eviltrout eviltrout merged commit 19e0fea into discourse:master Jul 15, 2013

1 check failed

default The Travis CI build failed
Details
@eviltrout

This comment has been minimized.

Show comment
Hide comment
@eviltrout

eviltrout Jul 15, 2013

Member

Looks fantastic! Thanks!

Member

eviltrout commented Jul 15, 2013

Looks fantastic! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment