Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: additionalOpts update and change to function #12546

Merged
merged 2 commits into from Mar 29, 2021
Merged

FIX: additionalOpts update and change to function #12546

merged 2 commits into from Mar 29, 2021

Conversation

fzngagan
Copy link
Contributor

@fzngagan fzngagan commented Mar 29, 2021 •
edited

@martin-brennan
I made this PR a few days back. I encountered an issue there. The additionalOpts object is added to the options inside a conditional which isn't desired. This resolves the issue.

@fzngagan fzngagan changed the title FIX: additionalOpts should be added outside conditional FIX: additionalOpts update and change to function Mar 29, 2021
@fzngagan
Copy link
Contributor Author

@eviltrout
I've added another change. The additionalOpts need to update on each call and hence, it better be a function. Hope that's acceptable.

@eviltrout eviltrout merged commit ff814dc into discourse:master Mar 29, 2021
@fzngagan fzngagan deleted the timer-fix branch March 30, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviltrout eviltrout eviltrout approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@fzngagan @eviltrout