New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a missing "#" to href for TOS. #1308

Merged
merged 1 commit into from Aug 7, 2013

Conversation

3 participants
@happycollision
Copy link
Contributor

happycollision commented Aug 7, 2013

Self explanatory. Love what you guys are doing.

PS - This is the first pull request I have ever made.

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Aug 7, 2013

Thanks for contributing this pull request! Could you please sign our CLA so we can review it? http://www.discourse.org/cla

eviltrout added a commit that referenced this pull request Aug 7, 2013

Merge pull request #1308 from happycollision/patch-1
Added a missing "#" to href for TOS.

@eviltrout eviltrout merged commit e02f9c2 into discourse:master Aug 7, 2013

1 check passed

default The Travis CI build passed
Details
@eviltrout

This comment has been minimized.

Copy link
Member

eviltrout commented Aug 7, 2013

Thanks! One issue here is Ember.js prevents links to ids so it won't work. But if we have a link in there, it should be pointing to the right thing so we can address the ember issue later.

@happycollision happycollision deleted the happycollision:patch-1 branch Sep 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment