Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "PERF: Cache categories in Site model take 2." #13465

Merged
merged 1 commit into from Jun 21, 2021
Merged

Revert "PERF: Cache categories in Site model take 2." #13465

merged 1 commit into from Jun 21, 2021

Conversation

riking
Copy link
Contributor

@riking riking commented Jun 21, 2021

This reverts commit 06fa1ef.

Breakage in solved plugin

@riking
Revert "PERF: Cache categories in Site model take 2."
eede485 
This reverts commit 06fa1ef.

Breakage in solved plugin
@eviltrout
Copy link
Contributor

cc @tgxworld this broke with the solved plugin in production.

@riking
Copy link
Contributor Author

riking commented Jun 21, 2021 •
edited

@tgxworld you probably need a compatibility layer on the JS side so that accesses to custom_fields also check preloaded_custom_fields. (Or just don't rename the field.)

@riking riking merged commit 83a6ad3 into discourse:master Jun 21, 2021
@riking riking deleted the revert-category-preloaded branch June 21, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jomaxro jomaxro jomaxro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@riking @eviltrout @jomaxro