FIX: should not receive topic invites from ignored users. #14746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ignored users can send notifications by inviting the ignorer to topics or PMs.
|
I know in the past we discussed hiding that people had ignored you, because it could be seen as an abuse vector. Maybe it would be better to silently fail here rather than show a message? |
vinothkannans
commented
Oct 28, 2021
app/models/topic.rb
Outdated
| .joins(:muted_user) | ||
| .where('NOT admin AND NOT moderator') | ||
| .exists? | ||
| raise NotAllowed.new(I18n.t("topic_invite.muted_invitee")) |
There was a problem hiding this comment.
it would be better to silently fail here rather than show a message?
@eviltrout we should do the same for muted users too, right?
There was a problem hiding this comment.
Yes, I think that's a good idea.
|
@eviltrout it's done. |
eviltrout
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ignored users can send notifications by inviting the ignorer to topics or PMs.