DEV: Introduce RenderGlimmer helper for use in widgets
#17592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows an arbitrary Glimmer template to be rendered inside a Widget. That template can include any kind content, including Classic Ember components and Glimmer components. This leans on Ember's official `{{#in-element}}` helper which means that all component lifecycle hooks are called correctly.
This is a modern replacement for our existing `ComponentConnector` implementation. We'll deprecate `ComponentConnector` in the near future.
Example usage:
```javascript
// (inside an existing widget)
html(){
return [
new RenderGlimmer(
this,
"div.my-wrapper-class",
hbs`<MyComponent @Arg1={{@data.arg1}} />`,
{
arg1: "some argument value"
}
),
]
}
```
See `widgets/render-glimmer.js` for documentation, and `render-glimmer-test` for more example uses.
davidtaylorhq
force-pushed
the
render-glimmer
branch
from
0b399c0
to
72e0bcc
Compare
CvX
approved these changes
Jul 21, 2022
app/assets/javascripts/discourse/tests/integration/components/widgets/render-glimmer-test.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/app/components/mount-widget.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/add-settings-to-your-discourse-theme/82557/77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an arbitrary Glimmer template to be rendered inside a Widget. That template can include any kind content, including Classic Ember components and Glimmer components. This leans on Ember's official
{{#in-element}}helper which means that all component lifecycle hooks are called correctly.This is a modern replacement for our existing
ComponentConnectorimplementation. We'll deprecateComponentConnectorin the near future.Example usage:
See
widgets/render-glimmer.jsfor documentation, andrender-glimmer-testfor more example uses.