UX: Remove Active cursor from dead button #18015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/suggested-topics-activity-column-sort-clickable-no-action/236632/4 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/suggested-topics-activity-column-sort-clickable-no-action/236632/5 |
pmusaraj
requested changes
Sep 13, 2022
There was a problem hiding this comment.
Thanks for this @darkpixlz and sorry for the delay.
From a quick inspection of this element, it looks like the style for it is set here:
Can you think of a reason why we shouldn't simply remove span { cursor: pointer } there?
|
We can definitely remove it there, I will fix when I'm out of class. |
|
Awesome, thanks @darkpixlz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTEXT:
https://meta.discourse.org/t/suggested-topics-activity-column-sort-clickable-no-action/236632
There is a broken link or dead button in the Suggested Topics list, this removed the clickable cursor.
Before:
After: