PERF: Adjust node memory threshold for assets:precompile
#19040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were forcing node's max-old-space-size to be 2GB. This override was added in a01b1dd to avoid issues caused by a lower default node heap_size_limit on machines with less memory. This commit makes that `max-old-space-size` override more specific so that it only applies to machines with less memory. Other machines will go use Node's defaults. The override is also lowered to 1GB. This is still high enough for the build to complete, while reducing memory usage. https://meta.discourse.org/t/245547
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/ember-is-huge-risks-failure-oom-on-minimum-instance-size/245547/5 |
CvX
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were forcing node's max-old-space-size to be 2GB. This override was added in a01b1dd to avoid issues caused by a lower default node heap_size_limit on machines with less memory.
This commit makes that
max-old-space-sizeoverride more specific so that it only applies to machines with less memory. Other machines will go use Node's defaults.The override is also lowered to 1GB. This is still high enough for the build to complete, while reducing memory usage.
https://meta.discourse.org/t/245547