UX: Sections not collapsable in "header dropdown" navigation menu #21604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the problem? This is a follow up to 4cca7de. In the commit, CSS was used to disable the collapsing of sections in the header dropdown navigation menu when the `navigation_menu` site setting is set to `header dropdown`. However, using CSS is not the correct approach as the underlying code is still marking the section as collapsable which means that the sections will still be displayed as collapsed with no way to "uncollapse" if the local store has already marked the section as collapsed. What is the fix? This commit removes the usage of CSS to hide the collapsabe button and instead correctly marks the section as not collapsable in the code.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
|
Thank you for the review @jjaffeux |
martin-brennan
pushed a commit
that referenced
this pull request
May 22, 2023
…1604) What is the problem? This is a follow up to 4cca7de. In the commit, CSS was used to disable the collapsing of sections in the header dropdown navigation menu when the `navigation_menu` site setting is set to `header dropdown`. However, using CSS is not the correct approach as the underlying code is still marking the section as collapsable which means that the sections will still be displayed as collapsed with no way to "uncollapse" if the local store has already marked the section as collapsed. What is the fix? This commit removes the usage of CSS to hide the collapsabe button and instead correctly marks the section as not collapsable in the code.
enduvar
pushed a commit
to ForgottenWorld/discourse
that referenced
this pull request
Sep 8, 2023
…scourse#21604) What is the problem? This is a follow up to 4cca7de. In the commit, CSS was used to disable the collapsing of sections in the header dropdown navigation menu when the `navigation_menu` site setting is set to `header dropdown`. However, using CSS is not the correct approach as the underlying code is still marking the section as collapsable which means that the sections will still be displayed as collapsed with no way to "uncollapse" if the local store has already marked the section as collapsed. What is the fix? This commit removes the usage of CSS to hide the collapsabe button and instead correctly marks the section as not collapsable in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem?
This is a follow up to 4cca7de. In the
commit, CSS was used to disable the collapsing of sections in the header
dropdown navigation menu when the
navigation_menusite setting is setto
header dropdown. However, using CSS is not the correct approach asthe underlying code is still marking the section as collapsable which
means that the sections will still be displayed as collapsed with no way
to "uncollapse" if the local store has already marked the section as
collapsed.
What is the fix?
This commit removes the usage of CSS to hide the collapsabe button and
instead correctly marks the section as not collapsable in the code.