Add minitest to gemfile #238

Merged
merged 1 commit into from Feb 23, 2013

Conversation

5 participants
Contributor

balpha commented Feb 23, 2013

Disclaimer: I have no idea what I'm doing. But I had to make this change to get Discourse to build on Fedora.

This is an unfortunate issue raised because fedora 17+18 made certain controversial choices in packaging system gems that the ruby/rails/bundler community are so far resistant to (some context - rails/rails#6907). As much as it pains me to say so - it's wrong for the fed18 distribution of ruby to make choices about gem and library makeup that are incompatible with the upstream maintainers, and the rails reaction is probably the correct (read: likely to prevail) one. I know we have hit several issues where including a gem in the gem ile caused issues on other ruby platforms, although that is unlikely to be the case for minitest.

Contributor

danneu commented Feb 23, 2013

Minitest is included in Ruby since Ruby 1.9. Sounds like you're on Ruby 1.8.

I recommend installing RVM to manage Ruby versions (and download/compile them for you), and then use it to install the latest Ruby 1.9.3.

Contributor

iangcarroll commented Feb 23, 2013

\curl -L https://get.rvm.io | bash -s stable --ruby
rvm install 1.9.3
rvm use 1.9.3 --default

The slash is intentional

Ruby 1.9 ships with fed17-18, but minitest is not included in the package.

Contributor

iangcarroll commented Feb 23, 2013

Then what's the harm in merging?

Don't think there is - just wanted to add context since a few other gems have caused issues for other rails apps, on different platforms

Contributor

balpha commented Feb 23, 2013

Interesting; not being a rubyist, I wasn't aware of this. If it doesn't cause issues, it makes sense to merge it anyway, but otherwise I don't mind if it's declined (but it probably makes sense to memtion it in the docs then).

SamSaffron added a commit that referenced this pull request Feb 23, 2013

@SamSaffron SamSaffron merged commit f83494d into discourse:master Feb 23, 2013

1 check passed

default The Travis build passed
Details
Owner

SamSaffron commented Feb 23, 2013

Interesting that Fedora are doing stuff differently, personally I would always prefer to be on RVM cause with Ruby you usually want to be on latest stable.

Additionally, stuff like the latest Ruby or patched versions of Ruby can make startup times twice as fast, something that is critical in dev.

All that said, adding another gem dependency that is actually there, is totally the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment