FEATURE: Add Ranked Choice Voting (using Instant Run-off Voting algorithm) to Poll Plugin (Part 2 add Ranked Choice)

[merefield]

**NB Glimmer only changes (also part of this PR) are in Part 1 #27204 **

• FEATURE: Adds Instant Run-off Voting Option to the Poll plugin aka "Ranked Choice".
• DEV: upgrades most of the front end to Glimmer

[merefield]

@jjaffeux responded to all your feedback thus far

[CvX]

Hi @merefield! Internally we talked briefly about the name "instant runoff voting"/"irv" since some of us were unfamiliar with those terms. (the apple dictionary suggests this is a "mainly US" noun, so maybe it's partly due to that 🤷)

Anyway, it was suggested to maybe go with an alternative name: "ranked choice" (per wikipedia: "Instant-runoff voting (IRV), also known as ranked-choice voting or the alternative vote (AV)"

Pros:

• people unfamiliar with "IRV" can roughly intuit what "ranked choice" means
• the full name "Instant Runoff Voting" is a mouthful, and "Ranked Choice" is both more concise and fits better with "Single Choice" and "Multiple Choice"
• we try to avoid using initialisms/acronyms in the code, with the exception of well known ones like SSL/HTTP

I opened a PR to your PR with the rename commit: merefield#4
It also simplifies one or two method names, like: DiscoursePoll::Irv.irv_outcome -> DiscoursePoll::RankedChoice.outcome

[merefield]

@CvX that makes a lot of sense.

Thanks for the PR.

I have a couple of urgent matters to take care of but will get to that in due course.

all good now

[merefield]

@CvX thanks for you PR, merged.

I really like this change.

If we ever offer additional ranked choice algo's in future, this is a really nice generalisation for areas where there will still be a general solution (e.g. rank drop-downs).

[merefield]

@CvX @jjaffeux @ZogStriP there is now an issue with tabs not showing for public ranked choice elections, I'm going to investigate, but please do not merge just yet.

[jjaffeux]

@merefield I will look at the this.args.rank/this.rank stuff now, this is due to deep issues, too complex to explain in a comments

[jjaffeux]

@merefield I will look at the this.args.rank/this.rank stuff now, this is due to deep issues, too complex to explain in a comments

Ok I give up on this for now, too big of a change

[merefield]

@jjaffeux to this PR or does it affect core in some way?

[jjaffeux]

We are doing a minor version bump soon, and will probably merge this right after

[ZogStriP]

Here we go 🚀 @merefield

[merefield]

Thanks for everyone's patience and assistance on this one ❤️