Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Flash Video onebox, set dimension via url using #WxH #2809

Closed
wants to merge 3 commits into from
Closed

Feature: Flash Video onebox, set dimension via url using #WxH #2809

wants to merge 3 commits into from

Conversation

lidlanca
Copy link
Contributor 

http://example.com/file.swf#640x360 // width 640px height:360px
http://example.com/file.swf#0x360   // width 100% height:360px
http://example.com/file.swf#640x0   // width 640px height:100%

@discoursebot
Copy link

You've signed the CLA, lidlanca. Thank you! This pull request is ready for review.

ZogStriP
ZogStriP reviewed Sep 22, 2014
View reviewed changes
lib/onebox/engine/flash_video_onebox.rb

def to_html
# Lidlanca 2014
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment isn't very useful. Author's information is kept in git, no need to duplicate it in the code.

@eviltrout
Copy link
Contributor

Ping, can we get an update on this one? Is the only thing holding it back removing that comment?

@ZogStriP
Copy link
Member

@lidlanca can you remove that comment and rebase so that there's only 1 commit? Thanks

@lidlanca lidlanca closed this Oct 15, 2014
@lidlanca lidlanca deleted the patch-4 branch October 15, 2014 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@lidlanca @discoursebot @eviltrout @ZogStriP