Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Extended user stats in user export csv #2936

Merged
merged 2 commits into from Nov 3, 2014

Conversation

@dfpfernandez
Copy link
Contributor

dfpfernandez commented Oct 31, 2014

@discoursebot
Copy link

discoursebot commented Oct 31, 2014

Thanks for contributing this pull request! Could you please sign our CLA so we can review it? http://www.discourse.org/cla

@@ -26,7 +26,10 @@ def execute(args)
user_data.each do |user|
user_array = Array.new
group_names = get_group_names(user).join(';')
user_array.push(user['id']).push(user['name']).push(user['username']).push(user['email'])
user_array.push(user['id']).push(user['name']).push(user['username']).push(user['email']).push(user['created_at'])

This comment has been minimized.

Copy link
@ZogStriP

ZogStriP Oct 31, 2014

Member

Hmm, I'm not sure I like this "syntax", there's way too much push for me. I think you could use 2 loops and it'd be better to the eyes ;)

@dfpfernandez
Copy link
Contributor Author

dfpfernandez commented Nov 3, 2014

you are right, is not very cute!! how about now?

thanks for the suggestion!!

@ZogStriP
Copy link
Member

ZogStriP commented Nov 3, 2014

@techAPJ mind reviewing this one since you've worked on this? ;)

@techAPJ
Copy link
Member

techAPJ commented Nov 3, 2014

Looks good to me! 👍

ZogStriP added a commit that referenced this pull request Nov 3, 2014
Feature: Extended user stats in user export csv
@ZogStriP ZogStriP merged commit a7fa1b3 into discourse:master Nov 3, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.