Fix rounding issue with humane.js (i.e. 60 minutes) #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've signed the CLA, tms. Thank you! This pull request is ready for review. |
|
one sec, this is in an external file, we should be patching it upstream, otherwise it will be wiped if we update. |
|
Yeah, I made a note to submit a patch upstream when I get home. The project has very few updates though, so it shouldn't be an immediate concern. |
|
oops looks like this can no longer be merged in, can you rebase? |
|
Hmm...it seems #392 removed humane.js altogether, so no sense in rebasing. I'll check to see if there's anything left to do. |
|
Closing for now, I think the solution would be fairly different. |
CvX
added a commit
that referenced
this pull request
May 19, 2021
Since 8ff3fff introduced the addressable gem as a runtime dependency, it's now possible to replace all custom URI encoding logic with addressable's methods. It does handle some characters differently - e.g. it now doesn't escape URLs in URI fragments (see the added test). Previous escaping behavior was reported as an issue in Discourse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Meta topic: “24 hours” Timestamp Should Probably Be “1 day”
Simple rounding issue. I've just patched it in Discourse, but I'll make a note to submit a PR to the source project as well.