Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
FIX: Importing user avatar when new user login by SSO #4213
This PR contains a rather big refactor. But essentially it's a fix to ensure overrides semantics. Now the code structures like setup non-persistent model, update attrs, persistent models and overrides.
@sam SSO is quite complicated in the core... One reason is to clean up process since it's getting complicated. Some changes depend on whether a record is save or not. The other one is the bug fix. I simply failed to find where is the problem in the beginning.
I can still find a place to enforce the sso_overrides_avatar in the old code if you'd like. Or I can write many more specs to address the possible problems?