Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the "develop inside Docker" experience #4450

Merged

Conversation

@JaredReisinger
Copy link
Contributor

commented Sep 20, 2016

This PR is intended to work in concert with the discourse_docker changes in discourse/discourse_docker#292. I have used those changes to build a local "discourse_dev" image, and then these changes to easily spin up and work on Discourse and plugin functionality. It's working well for me, but of course YMMV.

Add --init and --patch options to bin/docker/boot_dev to make it easier to spin up a container running Discourse out of a development directory.

Add bin/docker/README.md to explain how to go about using the docker command-line tools.

Tweak the Docker command-line tools to use the -u option to specify user rather than changing to the user "inside" the container via chpst (This way, we don't have to explicitly specify the HOME environment variable, either.)

Add bin/docker/shell command to make it easy to jump inside the running container.

This PR is intended to work in concert with the discourse_docker changes
in discourse/discourse_docker#292.  I have used
those changes to build a local "discourse_dev" image, and then
_**these**_ changes to easily spin up and work on Discourse and plugin
functionality.  It's working well for me, but of course YMMV.

Add `--init` and `--patch` options to bin/docker/boot_dev to make it
easier to spin up a container running Discourse out of a development
directory.

Add `bin/docker/README.md` to explain how to go about using the docker
command-line tools.

Tweak the Docker command-line tools to use the `-u` option to specify
user rather than changing to the user "inside" the container via `chpst`
(This way, we don't have to explicitly specify the HOME environment
variable, either.)

Add `bin/docker/shell` command to make it easy to jump inside the
running container.
@discoursebot

This comment has been minimized.

Copy link

commented Sep 20, 2016

You've signed the CLA, JaredReisinger. Thank you! This pull request is ready for review.

@coding-horror

This comment has been minimized.

Copy link
Member

commented Sep 20, 2016

You should review this @SamSaffron

@SamSaffron

This comment has been minimized.

Copy link
Member

commented Sep 21, 2016

very happy the templates are gone, added a bunch of comments and I am not sure where they are gone so will do review again

@SamSaffron

This comment has been minimized.

Copy link
Member

commented Oct 10, 2016

I am merging this now (prior to the discourse docker merge which is in progress) mainly to help clear off the queue here :)

Thanks @JaredReisinger !

@SamSaffron SamSaffron merged commit 41ce205 into discourse:master Oct 10, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zuzust

This comment has been minimized.

Copy link

commented on bin/docker/boot_dev in b7ea3de Dec 2, 2016

Docker image doesn't exist:

$ docker pull discourse/discourse_dev:latest
Pulling repository docker.io/discourse/discourse_dev
Error: image discourse/discourse_dev:latest not found
@JaredReisinger JaredReisinger deleted the JaredReisinger:improve-docker-development branch Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.