Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't look for external facts when benchmarking #4454

Merged
merged 1 commit into from Sep 21, 2016

Conversation

@JaredReisinger
Copy link
Contributor

commented Sep 21, 2016

When running scripts/bench.rb via the discourse/discourse_bench docker container, Facter throws an EACCES error attempting to load external puppet facts. Since the benchmark script ends up ignoring everything except for seven specific keys, we can just avoid loading any external fact logic entirely.

When running `scripts/bench.rb` via the discourse/discourse_bench docker
container, Facter throws an EACCES error attempting to load external
puppet facts.  Since the benchmark script ends up ignoring everything
except for seven specific keys, we can just avoid loading any external
fact logic entirely. can just
@discoursebot

This comment has been minimized.

Copy link

commented Sep 21, 2016

You've signed the CLA, JaredReisinger. Thank you! This pull request is ready for review.

@SamSaffron

This comment has been minimized.

Copy link
Member

commented Sep 21, 2016

cool!

@SamSaffron SamSaffron merged commit ff35ea8 into discourse:master Sep 21, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JaredReisinger JaredReisinger deleted the JaredReisinger:remove-external-facts branch Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.