Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for email whitelist/blacklist to GitHub auth #4457

Merged

Conversation

@JaredReisinger
Copy link
Contributor

commented Sep 22, 2016

If a site is configured for GitHub logins, and has an email domain whitelist, it's possible to get in a state where a new user is locked to a non-whitelist email (their GitHub primary) even though they have an alternate email that's on the whitelist. In all cases, the GitHub primary email is attempted first so that previously existing behavior will be the default.

  • Add whitelist/blacklist support to GithubAuthenticator (via EmailValidator)
  • Add multiple email support GithubAuthenticator
  • Add test specs for GithubAuthenticator
  • Add authenticator-agnostic "none of your email addresses are allowed" error message.
If a site is configured for GitHub logins, _**and**_ has an email domain
whitelist, it's possible to get in a state where a new user is locked to
a non-whitelist email (their GitHub primary) even though they have an
alternate email that's on the whitelist.  In all cases, the GitHub
primary email is attempted first so that previously existing behavior
will be the default.

- Add whitelist/blacklist support to GithubAuthenticator (via
  EmailValidator)

- Add multiple email support GithubAuthenticator

- Add test specs for GithubAuthenticator

- Add authenticator-agnostic "none of your email addresses are allowed"
  error message.
@discoursebot

This comment has been minimized.

Copy link

commented Sep 22, 2016

You've signed the CLA, JaredReisinger. Thank you! This pull request is ready for review.

@SamSaffron

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

Thanks heaps!

btw, team is away on yearly meetup next week so we are going to be a bit slow to respond to PRs

@SamSaffron SamSaffron merged commit df751ed into discourse:master Sep 22, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JaredReisinger JaredReisinger deleted the JaredReisinger:github-auth-with-email-whitelist branch Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.