Remove useless routing for ForumsController #4517

Merged
merged 1 commit into from Oct 27, 2016

Conversation

4 participants
@mrded
Contributor

mrded commented Oct 27, 2016

ForumsController doesn't provide all necessary methods for resources :forums.

$ bundle exec rake routes | grep forum
       forums GET      /forums(.:format)                forums#index
              POST     /forums(.:format)                forums#create
    new_forum GET      /forums/new(.:format)            forums#new
   edit_forum GET      /forums/:id/edit(.:format)       forums#edit
        forum GET      /forums/:id(.:format)            forums#show
              PATCH    /forums/:id(.:format)            forums#update
              PUT      /forums/:id(.:format)            forums#update
              DELETE   /forums/:id(.:format)            forums#destroy
   srv_status GET      /srv/status(.:format)            forums#status

ForumsController provides only status and home_redirect methods.

I don't see any reasons to keep it. I believe we should drop it, because it doesn't allow to create permalinks with forums/* address.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Oct 27, 2016

@mrded, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nlalonde, @ZogStriP and @eviltrout to be potential reviewers.

@mrded, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nlalonde, @ZogStriP and @eviltrout to be potential reviewers.

@discoursebot

This comment has been minimized.

Show comment
Hide comment
@discoursebot

discoursebot Oct 27, 2016

You've signed the CLA, mrded. Thank you! This pull request is ready for review.

You've signed the CLA, mrded. Thank you! This pull request is ready for review.

@eviltrout eviltrout merged commit e0c40b7 into discourse:master Oct 27, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@eviltrout

This comment has been minimized.

Show comment
Hide comment
@eviltrout

eviltrout Oct 27, 2016

Member

Thanks! That home_redirect method also seems unused to me if you are looking for a follow up PR :)

Member

eviltrout commented Oct 27, 2016

Thanks! That home_redirect method also seems unused to me if you are looking for a follow up PR :)

@mrded

This comment has been minimized.

Show comment
Hide comment
@mrded

mrded Oct 27, 2016

Contributor

Great, thanks. I really like how quick you guys are :)

Contributor

mrded commented Oct 27, 2016

Great, thanks. I really like how quick you guys are :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment