Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove personal email from fixtures #4704

Merged
merged 1 commit into from Feb 13, 2017
Merged

remove personal email from fixtures #4704

merged 1 commit into from Feb 13, 2017

Conversation

rimian
Copy link
Contributor

@rimian rimian commented Feb 13, 2017

I'm writing acceptance tests against the user fixture in my plugin. It would be a good idea to use a generic email address as I'd like to respect eviltrout's privacy and not have the email leak out into other repositories :)

I'm writing acceptance tests against the user fixture in my plugin. It would be a good idea to use a generic email address as I'd like to respect eviltrout's privacy :)
@mention-bot
Copy link

Thanks @rimian for your pull request 👍. By analyzing the blame information on this pull request, I identified @eviltrout to be potential reviewers.

@discoursebot
Copy link

You've signed the CLA, rimian. Thank you! This pull request is ready for review.

@SamSaffron
Copy link
Member

@eviltrout since it is your email :) note email is still there in the commit messages so I am not sure how much this is really important

@rimian
Copy link
Contributor Author

rimian commented Feb 13, 2017

@SamSaffron here's my test: https://github.com/choiceaustralia/choice-discourse/blob/master/test/javascripts/acceptance/choice-discourse-test.es6

I was checking the email address which means I need to hard code it in a third party repo. It would be good not to have to worry about it.

Many thanks!

@coding-horror coding-horror merged commit 13c7887 into discourse:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants