Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: server plugin outlet for indexable robots.txt #4705

Merged
merged 1 commit into from Feb 13, 2017

Conversation

5 participants
@vinothkannans
Copy link
Member

commented Feb 13, 2017

As per @SamSaffron's comment below I added a server plugin outlet.

There is no built in extensibility to robots.txt generation, this needs to be added so it does not overwrite it completely (instead plugin should inject the instructions). Otherwise, each time we touch robots.txt plugin needs to be updated.

https://meta.discourse.org/t/discourse-sitemap-plugin/40348/32?u=vinothkannans

@mention-bot

This comment has been minimized.

Copy link

commented Feb 13, 2017

Thanks @vinothkannans for your pull request 👍. By analyzing the blame information on this pull request, I identified @nlalonde and @eviltrout to be potential reviewers.

@discoursebot

This comment has been minimized.

Copy link

commented Feb 13, 2017

You've signed the CLA, vinothkannans. Thank you! This pull request is ready for review.

@coding-horror

This comment has been minimized.

Copy link
Member

commented Feb 13, 2017

can you review @SamSaffron

@SamSaffron

This comment has been minimized.

Copy link
Member

commented Feb 13, 2017

Seems fine to me, I will backport this to stable and beta so we can junk the override from the plugin

@SamSaffron SamSaffron merged commit 07b9c35 into discourse:master Feb 13, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.