Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discourseEmbedClass option and apply classname to iframe html #4850

Closed
wants to merge 1 commit into from
Closed

Conversation

patdavid
Copy link
Contributor

@patdavid patdavid commented May 3, 2017

This will allow the embed javascript to include a parameter
discourseEmbedClass that will be passed to the iframe page
where it will be parsed and applied to the iframe element
as a class.

This allows targeting of CSS for different embeds.

This will allow the embed javascript to include a parameter
`discourseEmbedClass` that will be passed to the iframe page
where it will be parsed and applied to the iframe <html> element
as a class.

This allows targeting of CSS for different embeds.
@mention-bot
Copy link

Thanks @patdavid for your pull request 👍. By analyzing the blame information on this pull request, I identified @eviltrout and @techapj to be potential reviewers.

@discoursebot
Copy link

Thanks for contributing this pull request! Could you please sign our CLA so we can review it? http://www.discourse.org/cla

@patdavid
Copy link
Contributor Author

patdavid commented May 3, 2017

@patdavid
Copy link
Contributor Author

patdavid commented May 3, 2017

Could possibly ping @SamSaffron and @ZogStriP as well.

@eviltrout
Copy link
Contributor

I don't like the idea of the client passing this through. It seems like it could easily be used for XSS issues.

It should be part of the embeddable_host model and then inserted automatically by the rails application, plus an admin interface to add the class name to the particular host.

@eviltrout eviltrout closed this May 3, 2017
@eviltrout
Copy link
Contributor

(Also I meant to say thanks for the effort! Sorry that came across as rude.)

It just needs to go back to the drawing board.

@patdavid
Copy link
Contributor Author

patdavid commented May 3, 2017

Even better! I don't have the depth of understanding required to probably help much in this case the embeddable_host model. :(

Is there something I could do to help with that in mind?

@eviltrout
Copy link
Contributor

I'll post in the meta topic. Maybe someone can offer to help you out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants