-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Allow docker test rake task to be used for single plugins #4973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow docker test rake task to be used for single plugins #4973
Conversation
This is useful for adding continuous integration to individual plugin repositories
You've signed the CLA, davidtaylorhq. Thank you! This pull request is ready for review. |
This is fine, but let's add some documentation for this somewhere first. |
Where would you like the documentation? As a comment at the top of the file? I think a list of all the possible environment variables is probably a bit long to fit in the description line
|
@SamSaffron I've added some documentation as comments, but maybe there's a better place for them to go? Once this is merged I'll also update my meta topic on plugin CI testing with the details. |
@SamSaffron I've updated this so it works with your new SKIP_CORE env variable, and also added the new ENV variables to the documentation at the top |
lib/tasks/docker.rake
Outdated
# running it anywhere else will likely fail | ||
# | ||
# Environment Variables (specific to this rake task) | ||
# => SKIP CORE set to 1 to skip core rspec tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing underscore here?
Thank you for all your work so far 👍 @davidtaylorhq |
@davidtaylorhq awesome! a big one missing is the ability to run all qunit tests for ALL plugins (without core) can you swing adding that? |
I'm not sure how to detect which qunit tests are for plugins or for core - as far as I can see qunit offers filtering by "Module" or keyword... nothing for test file path. Any ideas? |
yeah ... that has been my conundrum here as well :) I have no idea how to swing this but totally need it, maybe core can be hacked somehow to allow this? |
Ok cool, I'll have a look in more detail next week. |
For reference: second PR is here #4985 |
This is useful for adding continuous integration to individual plugin repositories. For example, I've just set up discourse-chat-integration to run its tests on travis automatically. (Currently it applies this patch manually).
This change adds support for a
SINGLE_PLUGIN
environment variable. If set, it only runs rspec tests for that specific plugin. If left unset, everything continues to function as it currently does.(Specific qunit tests can already be run using the
MODULE
orFILTER
environment variables)example travis file making use of this feature
working test