Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Do not reset link counts upon rebake #6733

Merged
merged 2 commits into from Dec 5, 2018

Conversation

4 participants
@davidtaylorhq
Copy link
Member

commented Dec 5, 2018

This was an indentation mistake introduced in 44eba0b. Pretty understandable, considering we are indented 8 levels deep in this method. The first commit corrects the issue and adds a test, the second commit refactors the method to reduce complexity.

(Please use rebase & merge, not squash, so that we keep the two commits separate)

davidtaylorhq added some commits Dec 5, 2018

FIX: Do not reset link counts when post is rebaked
This was an indentation mistake introduced in 44eba0b. Pretty understandable, considering we are indented 8 levels deep in this method. Will follow-up with a refactor to improve this.
REFACTOR: split `TopicLink#extract_from` into multiple methods
Also rename some confusing variables
@discoursebot

This comment has been minimized.

Copy link

commented Dec 5, 2018

You've signed the CLA, davidtaylorhq. Thank you! This pull request is ready for review.

@discoursebot

This comment has been minimized.

Copy link

commented Dec 5, 2018

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/editing-topic-or-topic-title-removes-the-click-count-badge-for-links-in-that-topic/102672/8

@ZogStriP ZogStriP merged commit a1d9aed into master Dec 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidtaylorhq davidtaylorhq deleted the topic-link-rebake branch Dec 6, 2018

@rboy1

This comment has been minimized.

Copy link

commented Dec 14, 2018

Quick question, so posts which have been rebaked before this patch was rolled out would have lost their link counts? Any way to retrieve them?

@davidtaylorhq

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2018

Unfortunately not, the records were erased from the database. The only possible way would be to extract the old values from an old database backup.

@rboy1

This comment has been minimized.

Copy link

commented Dec 15, 2018

Ok. One more question. How long before this rolls out to your enterprise customers ?

@davidtaylorhq

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2018

Sorry for the delay in response @rboy1 - this fix has already been deployed across all of our hosting. If you notice any further issues please do let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.