Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fixed edit category description redirecting without saving #7192

Merged
merged 2 commits into from Mar 18, 2019

Conversation

@venarius
Copy link
Contributor

commented Mar 17, 2019

When a user clicks on Edit Description in the edit category modal, he got redirected to the post without saving the edit on the category. This fix will open up a new tab when the user clicks on Edit Description and the edit category modal will stay open on the first page.

Resolves: https://meta.discourse.org/t/when-editing-a-category-clicking-edit-description-redirects-without-saving/111797

@discoursebot

This comment has been minimized.

Copy link

commented Mar 17, 2019

You've signed the CLA, venarius. Thank you! This pull request is ready for review.

@discoursebot

This comment has been minimized.

Copy link

commented Mar 17, 2019

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/when-editing-a-category-clicking-edit-description-redirects-without-saving/111797/5

@ZogStriP ZogStriP merged commit 22c75e1 into discourse:master Mar 18, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@ZogStriP

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Thanks 👍

@gschlager

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

@venarius You might want to configure prettier and eslint for your editor.
https://meta.discourse.org/t/code-linting-and-formatting-with-prettier/92981
https://meta.discourse.org/t/prettier-code-formatting-tool/93212

And I recommend installing overcommit to automatically run eslint and rubocop upon commit.

@venarius venarius deleted the venarius:edit_category_description_popup branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.