Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Only do plain text table detection if outside code #7436

Closed

Conversation

4 participants
@venarius
Copy link
Contributor

commented Apr 25, 2019

Plain text table detection now only happens outside of code fence blocks.

Resolves: https://meta.discourse.org/t/plain-text-table-detection-should-respect-code-fences/115894

@discoursebot

This comment has been minimized.

Copy link

commented Apr 25, 2019

You've signed the CLA, venarius. Thank you! This pull request is ready for review.

FIX: Only do plain text table detection if outside code
Co-authored-by: Vinoth Kannan <vinothkannan@vinkas.com>

@venarius venarius force-pushed the venarius:only_text_table_if_outside_code branch from a8af98a to 2214770 Apr 25, 2019

@discoursebot

This comment has been minimized.

Copy link

commented Apr 25, 2019

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/plain-text-table-detection-should-respect-code-fences/115894/6

@ZogStriP

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

Nice, is there a way this can be tested?

vinothkannans added a commit that referenced this pull request Apr 26, 2019

UX: Only do plain text table detection in outside code if HTML pastin…
…g enabled

Co-authored-by: Tim Lange <tim.lange@titanhq.de>
PR: #7436
@vinothkannans

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

Done as per commit dc2ee78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.