Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: RIP swipe-in menus on Android #7997

Merged

Conversation

@featheredtoast
Copy link
Member

commented Aug 12, 2019

This removes the side swipe-in menus for android.

@discoursebot

This comment has been minimized.

Copy link

commented Aug 12, 2019

You've signed the CLA, featheredtoast. Thank you! This pull request is ready for review.

@jjaffeux

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

@featheredtoast sorry I didn't follow any conversation on this, do you have some context please?

@davidtaylorhq

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Latest Android uses swipe-in gestures for navigation, so we can't use them for Discourse menus

https://www.androidcentral.com/android-q-getting-rid-back-button-side-swipe-gesture

FIX: RIP swipe-in menus on Android
In later versions of android, swipe-in from the sides on android triggers
forward/back functionality. We can no longer trigger menu swipes on android

https://www.androidcentral.com/android-q-getting-rid-back-button-side-swipe-gesture

@featheredtoast featheredtoast force-pushed the featheredtoast:no-swipe-in-menus-on-android branch from 42cd0b9 to 555a7aa Aug 12, 2019

@discoursereviewbot

This comment has been minimized.

Copy link

commented Aug 12, 2019

Jeff Wong posted:

👍 I've added a comment and a link to the commit message and fixed up the linting errors

@featheredtoast featheredtoast merged commit 7877383 into discourse:master Aug 13, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@featheredtoast featheredtoast deleted the featheredtoast:no-swipe-in-menus-on-android branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.