Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frontend tests on Travis #8089

Merged
merged 3 commits into from Sep 12, 2019

Conversation

@CvX
Copy link
Contributor

commented Sep 11, 2019

The only important change here is the distro update in Travis config (trusty to xenial).

This is required since the latest stable Chrome (77, released 2019-09-10) doesn't support trusty, its installation attempt fails, and we try to run tests on a pre-installed version of Chrome (62, from 2017-10-17).

There are no side effects to that upgrade so far in my tests, but if there are any objections to this bump, we probably could install Chrome 76 (i.e. the last one that supported trusty) manually.


Note: This PR doesn't fix the Travis build completely. Backend tests are failing too, see: discourse/discourse-assign#47 (comment)

@discoursebot

This comment has been minimized.

Copy link

commented Sep 11, 2019

You've signed the CLA, CvX. Thank you! This pull request is ready for review.

@SamSaffron

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

fail looks unrelated to me!

undefined method `assign_locks_flags=' for #Class:0x0000000006bd8840

 # ./plugins/discourse-assign/spec/integration/assign_spec.rb:77:in `bloc
@SamSaffron SamSaffron merged commit eeb8480 into discourse:master Sep 12, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.