Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Properly render server side plugin outlets #8106

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@OsamaSayegh
Copy link
Member

commented Sep 19, 2019

The behavior of the render helper method changed in Rails 6 so now the method doesn't render the template and return the output, instead it just returns the file content as-is. Context: https://meta.discourse.org/t/discourse-sitemap-plugin/40348/134?u=osama

The behavior of the `render` helper method changed in Rails 6 so now the method doesn't render the template and return the output, instead it just returns the file content as-is. Context: https://meta.discourse.org/t/discourse-sitemap-plugin/40348/134?u=osama
@discoursebot

This comment has been minimized.

Copy link

commented Sep 19, 2019

You've signed the CLA, OsamaSayegh. Thank you! This pull request is ready for review.

@discoursebot

This comment has been minimized.

Copy link

commented Sep 19, 2019

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/discourse-sitemap-plugin/40348/136

@OsamaSayegh OsamaSayegh merged commit 57db3c1 into master Sep 19, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Tidelift Dependencies checked
Details
@OsamaSayegh OsamaSayegh deleted the rails6-render-method branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.