Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: update action should be in setting-component mixin #8287

Merged
merged 1 commit into from Nov 2, 2019

Conversation

@jjaffeux
Copy link
Contributor

jjaffeux commented Nov 2, 2019

This was causing an exception on some component (eg: value-list in a theme-component setting) which couldn't find an action named update.

This was causing an exception on some component (eg: value-list in a theme-component setting) which couldn't find an action named update.
@jjaffeux jjaffeux requested a review from vinothkannans Nov 2, 2019
@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 2, 2019

You've signed the CLA, jjaffeux. Thank you! This pull request is ready for review.

@vinothkannans vinothkannans merged commit 8d69944 into discourse:master Nov 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 3, 2019

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/can-not-save-default-watched-category-tags/132472/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.