Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Count current penalty if it started more than 6 months ago #8313

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@udan11
Copy link
Member

udan11 commented Nov 7, 2019

If the current penalty started more than 6 months ago, UserHistory entry would not be considered when counting. It was possible for the user to have 0 penalties, but be silenced or suspended.

Before promoting, there is an additional check that ensures the users are not silenced or suspended, so no users were promoted by mistake.

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 7, 2019

You've signed the CLA, udan11. Thank you! This pull request is ready for review.

Copy link
Member

eviltrout left a comment

Seems reasonable to me, thanks!

@udan11 udan11 merged commit dfc002d into discourse:master Nov 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@udan11 udan11 deleted the udan11:fix_tl3_req branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.