Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Alias modules that are required rather than imported #8315

Merged
merged 3 commits into from Nov 8, 2019

Conversation

@markvanlan
Copy link
Member

markvanlan commented Nov 7, 2019

Simply moving checkForAlias to occur for all methods of importing/requiring modules

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 7, 2019

You've signed the CLA, markvanlan. Thank you! This pull request is ready for review.

@markvanlan markvanlan merged commit 47e3e56 into discourse:master Nov 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@markvanlan markvanlan deleted the markvanlan:alias-requires branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.