Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Do not skip some emails in user search #8317

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@udan11
Copy link
Member

udan11 commented Nov 8, 2019

It used to avoid the email addresses containing the plus sign.

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 8, 2019

You've signed the CLA, udan11. Thank you! This pull request is ready for review.

It used to skip the email addresses containing the plus sign.
@udan11 udan11 changed the title FIX: Do not avoid some emails in user search FIX: Do not skip some emails in user search Nov 8, 2019
@udan11 udan11 force-pushed the udan11:fix_plus branch from b4ce437 to 2de6857 Nov 8, 2019
@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 8, 2019

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/cannot-send-e-mails-to-addresses-having-plus-signs-from-the-composer/131148/2

Copy link
Member

eviltrout left a comment

Nice catch!

@udan11 udan11 merged commit 55bdd9e into discourse:master Nov 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@udan11 udan11 deleted the udan11:fix_plus branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.