Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: create_master_key got renamed #8325

Merged
merged 3 commits into from Nov 8, 2019

Conversation

@pfaffman
Copy link
Contributor

pfaffman commented Nov 8, 2019

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 8, 2019

You've signed the CLA, pfaffman. Thank you! This pull request is ready for review.

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 8, 2019

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/rake-api-key-get-broken/132948/1

@davidtaylorhq

This comment has been minimized.

Copy link
Member

davidtaylorhq commented Nov 8, 2019

Good catch - thanks @pfaffman. I think we should also rename this rake task to api:create, since this will always create a new key. It will never "get" an existing key.

@pfaffman pfaffman closed this Nov 8, 2019
@pfaffman pfaffman reopened this Nov 8, 2019
@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 8, 2019

You've signed the CLA, pfaffman. Thank you! This pull request is ready for review.

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 8, 2019

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/rake-api-key-get-broken/132948/8

@davidtaylorhq davidtaylorhq merged commit 63bd074 into discourse:master Nov 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pfaffman pfaffman deleted the pfaffman:patch-3 branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.