Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: s/\$redis/Discourse\.redis #8431

Merged
merged 7 commits into from Dec 3, 2019

Conversation

@jjaffeux
Copy link
Contributor

jjaffeux commented Nov 28, 2019

No description provided.

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 28, 2019

You've signed the CLA, jjaffeux. Thank you! This pull request is ready for review.

jjaffeux added 3 commits Nov 28, 2019
fix
fix
Copy link
Member

eviltrout left a comment

I can't possibly review this properly, but the approach looks good, and all tests pass. I think we should merge and fix any regressions.

@eviltrout

This comment has been minimized.

Copy link
Member

eviltrout commented Nov 28, 2019

Another thought - can we deprecate $redis with an error?

@jjaffeux

This comment has been minimized.

Copy link
Contributor Author

jjaffeux commented Nov 28, 2019

Another thought - can we deprecate $redis with an error?

Yew I would want to do this but want to do a check of plugins first

@eviltrout

This comment has been minimized.

Copy link
Member

eviltrout commented Nov 28, 2019

Sorry I should have said warning! Output something when it's used.

@jjaffeux

This comment has been minimized.

Copy link
Contributor Author

jjaffeux commented Nov 28, 2019

@eviltrout I added a rubocop rule which should do this

@jjaffeux jjaffeux requested a review from SamSaffron Nov 28, 2019
jjaffeux added 2 commits Dec 1, 2019
@SamSaffron

This comment has been minimized.

Copy link
Member

SamSaffron commented Dec 3, 2019

feel free to merge when you are comfortable.

@jjaffeux jjaffeux merged commit 0d3d2c4 into discourse:master Dec 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jjaffeux jjaffeux deleted the jjaffeux:discourse-redis branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.