Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Do not autocomplete categories or emojis in code blocks #8433

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@udan11
Copy link
Member

udan11 commented Nov 28, 2019

Emojis and category autocomplete show up often when writing code
snippets, which makes it easy to insert unwanted text by mistake.

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Nov 28, 2019

You've signed the CLA, udan11. Thank you! This pull request is ready for review.

Copy link
Member

eviltrout left a comment

This is not a bad solution, but I do think getCodeBlocks or inCodeBlock needs to be tested

Emojis and category autocomplete show up often when writing code
snippets, which makes it easy to insert unwanted text by mistake.
@udan11 udan11 force-pushed the udan11:fix_autocomplete_code branch from f2130dc to 80577dc Nov 29, 2019
@udan11 udan11 requested a review from eviltrout Nov 29, 2019
Copy link
Member

eviltrout left a comment

Very nice!

@udan11 udan11 merged commit b643526 into discourse:master Dec 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@udan11 udan11 deleted the udan11:fix_autocomplete_code branch Dec 2, 2019
SamSaffron added a commit that referenced this pull request Dec 2, 2019
…8433)"

This reverts commit b643526.

Sadly this introduces a regex runaway CPU condition, we will re-work
this so it is safe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.