Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember linting #8782

Merged
merged 9 commits into from Feb 5, 2020
Merged

Ember linting #8782

merged 9 commits into from Feb 5, 2020

Conversation

@markvanlan
Copy link
Member

markvanlan commented Jan 24, 2020

This adds the new Ember linting found in this repo - https://github.com/discourse/eslint-discourse-ember

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Jan 24, 2020

You've signed the CLA, markvanlan. Thank you! This pull request is ready for review.

@markvanlan markvanlan force-pushed the markvanlan:ember-linting branch from efa5b2b to 63a098d Feb 3, 2020
@markvanlan

This comment has been minimized.

Copy link
Member Author

markvanlan commented Feb 3, 2020

@eviltrout This is rebased onto the select-kit changes now in master. Good to commit?

@eviltrout

This comment has been minimized.

Copy link
Member

eviltrout commented Feb 3, 2020

Let's give Select Kit one more day just in case it has to be rolled back or anything.

@markvanlan markvanlan force-pushed the markvanlan:ember-linting branch from ad95efc to c65c43d Feb 5, 2020
@markvanlan markvanlan merged commit 499b57a into discourse:master Feb 5, 2020
6 checks passed
6 checks passed
PLUGINS-BACKEND
Details
CORE-BACKEND
Details
PLUGINS-FRONTEND
Details
CORE-FRONTEND
Details
PLUGINS-LINT
Details
CORE-LINT
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.