Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: enforces no-invalid-interactive linting rule #8907

Merged
merged 2 commits into from Feb 11, 2020

Conversation

@jjaffeux
Copy link
Contributor

jjaffeux commented Feb 10, 2020

No description provided.

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Feb 10, 2020

You've signed the CLA, jjaffeux. Thank you! This pull request is ready for review.

@jjaffeux jjaffeux requested a review from eviltrout Feb 10, 2020
Co-Authored-By: Jarek Radosz <jradosz@gmail.com>
Copy link
Member

eviltrout left a comment

This seems good but is more likely to break stuff than some of the other linting changes right? Considering we have a release scheduled for next week, how confident do you feel about it?

@jjaffeux

This comment has been minimized.

Copy link
Contributor Author

jjaffeux commented Feb 10, 2020

This seems good but is more likely to break stuff than some of the other linting changes right? Considering we have a release scheduled for next week, how confident do you feel about it?

I'm a little bit worried, the alert change I made is probably risky given the lot of different ways we use alerts and with different markup... maybe we wait

@jjaffeux jjaffeux merged commit 902d0e1 into discourse:master Feb 11, 2020
6 checks passed
6 checks passed
PLUGINS-BACKEND
Details
CORE-BACKEND
Details
PLUGINS-FRONTEND
Details
CORE-FRONTEND
Details
PLUGINS-LINT
Details
CORE-LINT
Details
@jjaffeux jjaffeux deleted the jjaffeux:no-invalid-interactive-linting branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.