Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: when unread reply notification exists don't create new #8921

Merged

Conversation

@lis2
Copy link
Contributor

lis2 commented Feb 10, 2020

From time to time, the user is creating a reply post and then they want to add additional details. They edit an existing post and for example, add a quote from a previous one.

In that situation, if the user to whom reply was directed to already have the unread notification, we should not create the new one.

That behaviour was mentioned here: https://meta.discourse.org/t/reply-then-edit-to-add-quote-notification-redundancy/138358

From time to time, the user is creating a reply post and then they want to add additional details. They edit an existing post and for example, add a quote from a previous one.

In that situation, if the user to whom reply was directed to already have the unread notification, we should not create the new one.

That behaviour was mentioned here: https://meta.discourse.org/t/reply-then-edit-to-add-quote-notification-redundancy/138358
@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Feb 10, 2020

You've signed the CLA, lis2. Thank you! This pull request is ready for review.

@lis2 lis2 requested a review from SamSaffron Feb 11, 2020
@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Feb 11, 2020

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/reply-then-edit-to-add-quote-notification-redundancy/138358/18

Copy link
Member

eviltrout left a comment

Looks good to me!

app/services/post_alerter.rb Outdated Show resolved Hide resolved
@lis2 lis2 force-pushed the lis2:no-notification-when-unread-reply-exists branch from a5511ba to 3350672 Feb 12, 2020
@lis2

This comment has been minimized.

Copy link
Contributor Author

lis2 commented Feb 12, 2020

@SamSaffron could you review it? Regis and Robin reviewed and accepted it before our conversation worth 1 million dollars.

@SamSaffron SamSaffron merged commit e90f9e5 into discourse:master Feb 14, 2020
7 checks passed
7 checks passed
PLUGINS-BACKEND
Details
CORE-BACKEND
Details
PLUGINS-FRONTEND
Details
CORE-FRONTEND
Details
PLUGINS-LINT
Details
CORE-LINT
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.