Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Topics should honor auto-close when published to category #8963

Open
wants to merge 3 commits into
base: master
from

Conversation

@tshenry
Copy link
Member

tshenry commented Feb 13, 2020

This is my attempt to fix the issue outlined at:
https://meta.discourse.org/t/not-autoclosing-topics-published-from-another-category/138898

I suspect there may be more to the puzzle, but in any case, I'm looking forward to any feedback.

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Feb 13, 2020

You've signed the CLA, tshenry. Thank you! This pull request is ready for review.

@eviltrout

This comment has been minimized.

Copy link
Member

eviltrout commented Feb 14, 2020

This looks like it could be the correct solution, but we're going to need a test to confirm it's working.

The test should run the auto publish job with an auto-close set on the category, then confirm that the new published topic has the correct setting.

tshenry added 2 commits Feb 15, 2020
@tshenry

This comment has been minimized.

Copy link
Member Author

tshenry commented Feb 15, 2020

This is my first go at writing a test, so let me know if I need to tweak anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.