New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract InviteRedeemer from Invite #927

Merged
merged 1 commit into from May 31, 2013

Conversation

4 participants
@bplexico
Contributor

bplexico commented May 30, 2013

Extracted the InviteRedeemer class to decrease the complexity of the Invite.redeem method.

@discoursebot

This comment has been minimized.

Show comment
Hide comment
@discoursebot

discoursebot May 30, 2013

You've signed the CLA, bplexico. Thank you! This pull request is ready for review.

discoursebot commented May 30, 2013

You've signed the CLA, bplexico. Thank you! This pull request is ready for review.

@SamSaffron

This comment has been minimized.

Show comment
Hide comment
@SamSaffron

SamSaffron May 31, 2013

Member

this looks good to me, can you confirm the test coverage is good here?

Member

SamSaffron commented May 31, 2013

this looks good to me, can you confirm the test coverage is good here?

@bplexico

This comment has been minimized.

Show comment
Hide comment
@bplexico

bplexico May 31, 2013

Contributor

Yes, just double checked. Coverage is very good for this section.

Contributor

bplexico commented May 31, 2013

Yes, just double checked. Coverage is very good for this section.

eviltrout added a commit that referenced this pull request May 31, 2013

@eviltrout eviltrout merged commit 830b780 into discourse:master May 31, 2013

1 check passed

default The Travis CI build passed
Details
@eviltrout

This comment has been minimized.

Show comment
Hide comment
@eviltrout

eviltrout May 31, 2013

Member

I'm happy to accept it then! Thanks 🐟

Member

eviltrout commented May 31, 2013

I'm happy to accept it then! Thanks 🐟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment