FIX: Remove date from bookmark reminder non-English translations #9354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this was already done for english, now fixed for other languages
martin-brennan
deleted the
issue/fix-bookmark-reminder-non-english-translations
branch
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/improved-bookmarks-with-reminders/144542/70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
{{date}}interpolated value was removed from the English translations in #9329 but not from the other translations, causing breakages:Also adds a
,inbetween date and time for reminders usinglong_no_yearfor readability.