FEATURE: notify admins about old credentials #9854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security and API keys should be renewed periodically. This additional notification should help admins keep their Discourse safe and secure.
lis2
force-pushed
the
reminder-about-old-keys
branch
2 times, most recently
from
4d3c853
to
c148b3b
Compare
eviltrout
suggested changes
May 22, 2020
lis2
force-pushed
the
reminder-about-old-keys
branch
from
15037b4
to
ef4ab18
Compare
lis2
force-pushed
the
reminder-about-old-keys
branch
from
ef4ab18
to
c2b6585
Compare
|
@eviltrout thank you for the feedback. I fixed it. I think that old keys setting is very specific to this problem, so I didn't want to move that to SiteSettings model. Instead, I extended the test for "execute" method so there is no more need to test private methods. |
eviltrout
approved these changes
May 25, 2020
tgxworld
reviewed
May 26, 2020
Comment on lines
57
to
59
| setting_key_messages = old_site_settings_keys.map { |key| "#{key.name} - #{key.updated_at}" } | ||
| api_key_messages = old_api_keys.map { |key| "#{[key.description, key.user&.username, key.created_at].compact.join(" - ")}" } | ||
| [setting_key_messages | api_key_messages].join("\n") |
There was a problem hiding this comment.
Minor but instead of two intermediate arrays, because we can just push into an existing array?
There was a problem hiding this comment.
Thank you! nice catch, fixed and I will merge that stuff tomorrow in the morning :)
There was a problem hiding this comment.
Btw I left a small comment in dev about the design of this feature in https://dev.discourse.org/t/automatic-reminder-to-reset-old-machine-generated-secrets/16311/9
lis2
added a commit
that referenced
this pull request
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security and API keys should be renewed periodically.
This additional notification should help admins keep their Discourse safe and secure.