Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated methods and rubocop #215

Merged
merged 5 commits into from Oct 21, 2019

Conversation

@lis2
Copy link
Contributor

lis2 commented Oct 20, 2019

Housekeeping, deprecated Minitest methods and Rubocop magic comment

@jeremyevans

This comment has been minimized.

Copy link
Collaborator

jeremyevans commented Oct 20, 2019

Alternatively, if we don't want to uglify the specs, we could use minitest-global_expectations and we would only need to change a couple lines.

@SamSaffron

This comment has been minimized.

Copy link
Member

SamSaffron commented Oct 20, 2019

I am with Jeremy here @lis2, lets just pull in mini-test-global_expectations

This new pattern does make the spec suite quite ugly.

@lis2

This comment has been minimized.

Copy link
Contributor Author

lis2 commented Oct 20, 2019

@jeremyevans @SamSaffron fair point :) fixed

@SamSaffron

This comment has been minimized.

Copy link
Member

SamSaffron commented Oct 21, 2019

Looks great now! thanks!

@SamSaffron SamSaffron merged commit a07c518 into discourse:master Oct 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.