Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication in templates by having a layout file #61

Closed
krainboltgreene opened this issue Aug 21, 2013 · 0 comments
Closed

Reduce duplication in templates by having a layout file #61

krainboltgreene opened this issue Aug 21, 2013 · 0 comments
Labels
enhancement
Milestone
1.1.0

Comments

@krainboltgreene
Copy link

We want to reduce the duplicated parts of each template by having a shared layout view.
@ghost ghost assigned jzeta Sep 25, 2013
jzeta added a commit that referenced this issue Sep 25, 2013
@jzeta
move generic template vars to new default layout template #61
d01e80f
jzeta added a commit that referenced this issue Sep 25, 2013
@jzeta
refactor engine module to render onebox engine template within defaul…
5ff2574 
…t layout template #61
jzeta added a commit that referenced this issue Sep 25, 2013
@jzeta
move generic template vars to new default layout template #61
be16b77
jzeta added a commit that referenced this issue Sep 25, 2013
@jzeta
refactor engine module to render onebox engine template within defaul…
5209e41 
…t layout template #61
jzeta added a commit that referenced this issue Sep 25, 2013
@jzeta
create new layout class to handle template rendering #61
68baa52
jzeta added a commit that referenced this issue Sep 25, 2013
@jzeta
move rendering methods to new layout class, refactor #61
1e296da
jzeta added a commit that referenced this issue Sep 25, 2013
@jzeta
mustache template partials use two curls and gt, not triple curl #61
102c205
jzeta added a commit that referenced this issue Sep 25, 2013
@jzeta
require layout class in onebox module #61
7db3d6c
jzeta added a commit that referenced this issue Sep 26, 2013
@jzeta
using mustache instead of handlebars b/c no good support for ruby #61
a551812
jzeta added a commit that referenced this issue Sep 26, 2013
@jzeta
we want to have a generic name for a class that we will be reusing #61
cc70195
jzeta added a commit that referenced this issue Sep 26, 2013
@jzeta
update templates extension in onebox test to be .mustache #61
cbe42dd
jzeta added a commit that referenced this issue Sep 26, 2013
@jzeta
use @view as partial in layout template #61
798546e
jzeta added a commit that referenced this issue Sep 26, 2013
@jzeta
refactor view class to dynamically render as partial template or as l…
fa2fae2 
…ayout #61
jzeta added a commit that referenced this issue Sep 26, 2013
@jzeta
update #to_html arguments to render layout template #61
5077d3a
jzeta added a commit that referenced this issue Sep 27, 2013
@jzeta
escape partial in layout template #61
fe5a324
jzeta added a commit that referenced this issue Sep 27, 2013
@jzeta
refactor view class so template isn't created until needed #61
73a2dff
jzeta added a commit that referenced this issue Sep 27, 2013
@jzeta
we don't want to create template until it is needed in engine module #61
82a5040
jzeta added a commit that referenced this issue Sep 27, 2013
@jzeta
we want all oneboxes to be created consistently, all with templates #61
ac37483
jzeta added a commit that referenced this issue Sep 27, 2013
@jzeta
we need to override a fake onebox engine's #view method to make tests…
6229009 
… pass. also delete #template_path test since now in view class #61
jzeta added a commit that referenced this issue Sep 27, 2013
@jzeta
attr reader for view needed for fake onebox engines in specs #61
0ce3e2b
jzeta added a commit that referenced this issue Sep 27, 2013
@jzeta
layout template should be only template where triple curl is allowed #61
9fa7af7
jzeta added a commit that referenced this issue Sep 27, 2013
@jzeta
create spec for view class to test template rendering #61
c86860a
@jzeta jzeta closed this as completed in df55b5b Sep 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@krainboltgreene @jzeta