New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popup in popup #6
Conversation
client/views/popup.js
Outdated
@@ -69,6 +69,11 @@ class Popup { | |||
this.el = document.createElement('div'); | |||
this.el.className = 'discovery-view-popup'; | |||
|
|||
Popup.els = Popup.els || new Set(); | |||
Popup.els.add(this.el); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need this for?
client/views/popup.js
Outdated
Popup.els = Popup.els || new Set(); | ||
Popup.els.add(this.el); | ||
|
||
Popup.elQueue = Popup.elQueue || new Set(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to make it public? Maybe local variable instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it does make sense. I'll change this.
client/views/popup.js
Outdated
@@ -119,6 +124,12 @@ class Popup { | |||
const availWidthLeft = box.left - viewport.right - 3; | |||
const availWidthRight = viewport.right - box.left - 3; | |||
|
|||
[...Popup.els] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand what happens here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that was experiments. Forgot to remove.
No description provided.