remove: disgo.OS
#366
Merged
remove: disgo.OS
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the reason for this change? |
|
See updated https://github.com/disgoorg/disgo/pull/366#issue-2370847615#references |
|
Also, |
Malix-Labs
changed the title
disgo.getOS
|
while I can't exactly tell you why this was introduced in the first place since it's been over 2y lol, it was prob to make it easily overwritable, the structure has been quite different back then and this seems to has stuck with us since. These days you can overwrite this differently so it's prob fine to get completely rid off the const & replace it with |
|
Done |
topi314
approved these changes
Jun 24, 2024
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
"windows","darwin","linux", and every other Golang supported OSes