Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenID PHP 5.3 fixes #161

GoogleCodeExporter opened this issue Mar 14, 2015 · 5 comments

OpenID PHP 5.3 fixes #161

GoogleCodeExporter opened this issue Mar 14, 2015 · 5 comments


Copy link

Current OpenID plugin version 3.3.2 doesn't work with PHP 5.3. The fix is 
well known, see e.g.
3/. The subversion trunk still doesn't have this fix so I'd like to repost 
it here:

--- openid/Auth/OpenID/Server.php   2009-11-07 01:52:58.000000000 +0200
+++ openid-fixed/Auth/OpenID/Server.php 2009-11-26 17:32:43.000000000 +0200
@@ -1573,7 +1573,7 @@

         if (!is_a($handlerCls, 'Auth_OpenID_ServerError')) {
             return call_user_func_array(array($handlerCls, 'fromMessage'),
-                                        array($message, $this->server));
+                                        array(&$message, $this->server));
         } else {
             return $handlerCls;
@@ -1699,7 +1699,7 @@
         if (method_exists($this, "openid_" . $request->mode)) {
             $handler = array($this, "openid_" . $request->mode);
-            return call_user_func($handler, $request);
+            return call_user_func($handler, &$request);
         return null;

Hope this fix will be incorporated in the next version.

Original issue reported on by on 17 Mar 2010 at 12:41

Copy link

This worked for me, and it fixed my OpenID provider, but my OpenID commenting 
facility is still broken. Thanks for all the good work Diso project

Original comment by on 23 Aug 2010 at 8:54

Copy link

Can someone incorporate this into trunk and release a version? Pretty please?

Original comment by on 2 Sep 2010 at 5:26

Copy link

This has yet not been fixed in source:

Original comment by on 1 Jul 2011 at 10:54

Copy link

The source in this Google Code project is seriously out of date, so I've 
removed it and added a pointer to the github repository.  The second change in 
the patch above was fixed in this update[0] from August 2010.  I'm pretty sure 
the first change isn't actually necessary, since the 'fromMessage' function 
only reads data from the $message object.  It doesn't modify the object, so 
shouldn't really matter if it's a reference or not.  If this does turn out to 
be a real problem, it needs to be fixed in the upstream library[1].

Marking as fixed.  If there are still issues, please open a new bug on the 
github project.


Original comment by wnorris on 2 Jan 2012 at 6:11

  • Changed state: Fixed

Copy link

after looking at this a little more (along with this patch:
99), I'm pretty sure the above patch doesn't work anyway.

Original comment by wnorris on 2 Jan 2012 at 10:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

1 participant