New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift 2.6 bump #100

Merged
merged 6 commits into from Mar 7, 2015

Conversation

2 participants
@farmdawgnation
Copy link
Member

farmdawgnation commented Jan 11, 2015

As requested from ticket #92, this PR bumps dispatch's lift-json dependency to the 2.6 Final which was released today. It looks like some tweaking may be needed for the unfiltered dependency and I'll need someone else to verify things still compile under 2.9.x. My local install of sbt doesn't seem to allow you to get away with the 2.9 configuration we're using here:

[error] Modules were resolved with conflicting cross-version suffixes in {file:/Users/matt/Projects/reboot/}lift-json:
[error]    net.liftweb:lift-json _2.9.2, _2.9.1

What was the reasoning behind that, again?

That said, depending on 2.6 final should allow you guys to start building liftjson as a part of your regular release cycle again.

Cheers!

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Feb 6, 2015

Can we get any love / help on this?

@n8han

This comment has been minimized.

Copy link

n8han commented Feb 7, 2015

What was the reasoning behind that, again?

What version of lift-json should we point to for our 2.9.3 build?

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Feb 8, 2015

What version of lift-json should we point to for our 2.9.3 build?

Ah. The dispatch-liftjson module shouldn't be built for 2.9.3. We've never issued a 2.9.3 build, and probably won't since after 2.6 we're dropping everything before 2.10 from our support matrix.

@n8han

This comment has been minimized.

Copy link

n8han commented Feb 8, 2015

Right, so all we have to do is convince sbt it shouldn't build the module for that version of scala and we'd be in good shape. This is something I've never found a reliable solution for, hence the series of hacks for libraries that aren't compiled against every version of scala. 😮

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Feb 8, 2015

I have some ideas about that...

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Feb 21, 2015

Wow, ok, so I have finally emerged from a hellish few weeks and can finally look at this... heh.

farmdawgnation added some commits Feb 21, 2015

Don't build the lift-json module for 2.9.3.
Today's magical sbt incantation is *drumroll* SKIP! This will cause the
lift-json project to skip its compile phase if compile is invoked on
dispatch-all. It will still run its update phase, so we have to do some
weird cross version mapping because of the build definition of
unfiltered-json. I think if we can sort out the build issues in
unfiltered-json and have a 2.11 release spun of that, we will be able to
simplify this code.
@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Feb 21, 2015

Hey @n8han I think I have your solution. This doesn't entirely get us to building the liftjson module for 2.11 because we need a 2.11 version of unfiltered-json or we need to remove that dependency from the tests.

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Feb 21, 2015

Yeah, I think the right answer here is to remove unfiltered from the tests and rewrite the test. The test hits other components (e.g. the Http handler) and doesn't really box itself off to just test the json parser. I can mix in mockito and make that happen if you agree that it's the best path to go down.

@n8han

This comment has been minimized.

Copy link

n8han commented Feb 28, 2015

This looks like the right direction, and I agree we should remove unfiltered-json from the tests as that module is no longer published.

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Mar 3, 2015

Ok, cool. I'll try to make time to throw some Mockito in the mix Real Soon Like™. Maybe tomorrow?

@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Mar 7, 2015

Alright, @n8han – I think we're good for another look (and maybe a merge?????) here. :-)

@n8han n8han added this to the 0.11.3 milestone Mar 7, 2015

@n8han

This comment has been minimized.

Copy link

n8han commented Mar 7, 2015

Looks good!

n8han pushed a commit that referenced this pull request Mar 7, 2015

Nathan Hamblen

@n8han n8han merged commit 1579cae into dispatch:0.11.3 Mar 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@farmdawgnation

This comment has been minimized.

Copy link
Member

farmdawgnation commented Mar 7, 2015

Woohoo! Great! When this is released I'll be able to undo a bunch of hacks I did in my projects. >_> lol

@farmdawgnation farmdawgnation deleted the farmdawgnation:lift_26_bump branch Mar 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment